Skip to content

Fix validation constraints for parameters in request body of form request are not generated (at least with Spring Boot generator)#21749

Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom
oliverkuntze:fix-form-request-param-validation
Aug 23, 2025
Merged

Fix validation constraints for parameters in request body of form request are not generated (at least with Spring Boot generator)#21749
wing328 merged 4 commits intoOpenAPITools:masterfrom
oliverkuntze:fix-form-request-param-validation

Conversation

@oliverkuntze
Copy link
Copy Markdown
Contributor

@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @Zomzog @martin-mfg

Validation constraints like minLength, maxLength, pattern defined for parameters within request bodies of
application/x-www-form-urlencoded content are not generated in the API interfaces.

The formParams.mustache is missing the beanValidationBodyParams template call (as opposed for example to the regular bodyParams.mustache).

This PR fixes it for the Spring generator.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 16, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 16, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/16968373859/job/48211714077?pr=21749

please follow step 3 to update the samples

https://github.com/OpenAPITools/openapi-generator/actions/runs/16968373866/job/48211619581?pr=21749

that's fixed in the latest master. please merge it into your branch

thanks for the contribution

@oliverkuntze oliverkuntze force-pushed the fix-form-request-param-validation branch from 690315a to e847cbe Compare August 16, 2025 14:48
@oliverkuntze
Copy link
Copy Markdown
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Thanks for the hint! Fixed.

@oliverkuntze
Copy link
Copy Markdown
Contributor Author

oliverkuntze commented Aug 16, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/16968373859/job/48211714077?pr=21749

please follow step 3 to update the samples

https://github.com/OpenAPITools/openapi-generator/actions/runs/16968373866/job/48211619581?pr=21749

that's fixed in the latest master. please merge it into your branch

thanks for the contribution

I merged the latest master into my branch.

Added the samples that were created during the bin/generate-samples.sh run.

@oliverkuntze
Copy link
Copy Markdown
Contributor Author

@wing328 Do you have any idea when the pr could be merged? :-)

@wing328 wing328 modified the milestones: 7.15.0, 7.16.0 Aug 22, 2025
@wing328 wing328 merged commit cd7fe34 into OpenAPITools:master Aug 23, 2025
85 of 88 checks passed
@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 23, 2025

just merged it.

thanks for the contribution.

have a nice weekend.

@oliverkuntze
Copy link
Copy Markdown
Contributor Author

Great! Thanks a lot!
Have a nice weekend, too.

Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
…uest are not generated (at least with Spring Boot generator) (OpenAPITools#21749)

* fix(Spring Boot): adds validation to body params of forms requests

* fix(Spring Boot): adds test for validation of body params of forms requests

* fix(Spring Boot): adds samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants